feat(landing): bridge the notification, settings and billing deep-link routes - #13
Merged
Conversation
…g routes Mirrors the three navigate routes added to the client's ROUTES table. The settings section list and the notification id cap are copies of the client's own, so a link the app cannot render fails on the page instead of hopping to a scheme URL that gets dropped in silence.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of VoltiusApp/voltius#144, page half. Mirrors the three
navigateroutes added to the client'sROUTEStable in VoltiusApp/voltius (companion PR), so anhttps://voltius.app/open#…link for them hops to the scheme URL instead of rendering "This link is incomplete".notification— optional opaquen, length-capped at 200 to match the client. Inbox ids are re-derived from server state, so an id the app no longer holds simply opens the notification centre.settings—sectionchecked against a copy of the client'sSETTINGS_SECTIONS. Notemcpis not a section (MCP lives insideintegrations), so#settings?section=mcpis rejected.billing— no parameters; buildsvoltius://billing. The client opens the account section and deliberately starts no checkout.plugin/install,snippet/installandconnectstay rejected, with tests asserting it.The two whitelists must agree or links die silently, so the client PR merges first. 31 landing tests pass;
pnpm lintclean.